Fix LT-20337: Crash Navigating From Bulk Edit Phoneme Features#426
Merged
Conversation
jasonleenaylor
approved these changes
Aug 5, 2025
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Src/LexText/LexTextControls/PhonologicalFeaturePopupTreeManager.cs line 229 at r1 (raw file):
cmBaseAnnotation.Delete(); else m_annotations.Remove(cmBaseAnnotation);
I was about to say this would invalidate the iterator, but then I noticed your 'ToList()' addition. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-20337. However, I'm worried that it is only a band-aid fix, and the problem will also show up elsewhere.
This change is